Are Code Reviews Worth It? 345
JamaicaBay writes "I'm a development manager, and the other day my boss and I got into an argument over whether it's worth doing code reviews. In my shop we've done both code reviews and design reviews. They are all programmer-led. What we've found is that code reviews take forever and tend to reveal less than good UI-level testing would. The payback on design reviews, meanwhile, is tremendous. Our code is intended for desktop, non-critical use, so I asked my boss to consider whether it was worth spending so much time on examining built code, given our experience not getting much out of it. I'm wondering whether the Slashdot crowd's experience has been similar."
Are they worth it? (Score:1, Funny)
No.
Discussion over, everyone go home.
Re:Synergy, leverage, low hanging fruit, etc.. (Score:5, Funny)
If you truly want to make a decision on whether code reviews are worth it.. you need to know[...]
So what you're saying is we have to have a review of the reviews...we're going to be here a while aren't we?
Line them up (Score:5, Funny)
Have each developer line up with his/her/its code printed out on a cue card board and stand in a line up. Execute the least likely to make it to the compiler, then you will "motivate" the rest to write better code..
Re:If you're code review is taking forever... (Score:2, Funny)
Re:Synergy, leverage, low hanging fruit, etc.. (Score:3, Funny)
Well, in that case, we should do a thorougly review of the reviews of the reviewed review reviews.
BUFFER OVERRIDE
a fucktonne? (Score:5, Funny)
Damn europeans and their metric system.
How many shitloads are in a fucktonne?
Re:If you're code review is taking forever... (Score:3, Funny)
Re:they are worth it (Score:3, Funny)
No, no, no. If you are shipping bugs the problem is that the bugs are introduced in the first place.
Can I come live in your fantasy world where programmers write perfect code every time?
Re:Synergy, leverage, low hanging fruit, etc.. (Score:4, Funny)
Hire programmers who don't get hit by busses. (Score:3, Funny)
I keep hearing about these programmers getting hit by busses. In fact, I think I hear about programmers being hit by busses more than members of any other profession. Now, the busses that I've seen tend to be rather large things that stop frequently, and usually aren't going very fast. The generally poor quality of code suddenly makes a lot more sense when you consider that it is being written by a class of people who are so fatally inattentive as to be struck by busses with such improbable frequency.
Re:Are they worth it? (Score:5, Funny)
In my experience, unicorns are 2.7 times better than mermaids at debugging.
Re:a fucktonne? (Score:2, Funny)
How many shitloads are in a fucktonne?
Wolfram Alpha knows ;-)